Related Projects
Bug p319

Project Lead:

jjgignac (0 credits)

 

Bounty:

US $0.00(Sponsor Project)

Goal funding:

More Less
Reference signs in function calls are disallowed in PHP 5.4 and later.

Status:

[COMPLETE]

The final payment was made to Rev22 on Fri, Jul 6, 2012. This project is complete; no new sponsorships or submissions will be accepted. You can continue to use the forums for discussion purposes.

Note: You can propose changes using the forum below.
Reference signs in function calls are disallowed in PHP 5.4 and later.

http://stackoverflow.com/questions/8971261/php-5-4-call-time-pass-by-reference-easy-fix-available

This currently only happens in calls to private_add_post in db.php, and is trivial to fix:

diff --git a/source/db.php b/source/db.php
index a57ed82..02c3563 100644
--- a/source/db.php
+++ b/source/db.php
@@ -906,7 +917,7 @@
              " ancestry like '$ancestry%' order by id");
          if( $qu === false) return private_dberr();
 
-         private_add_post( &$posts, &$toplevel, $qu);
+         private_add_post( $posts, $toplevel, $qu);
      } else {
          $mindepth = strlen(ereg_replace("[^/]","",$ancestry))-1;
 
@@ -917,7 +928,7 @@
              if( $qu === false) return private_dberr();
              if( sql_numrows( $qu) == 0) break;
 
-             private_add_post( &$posts, &$toplevel, $qu);
+             private_add_post( $posts, $toplevel, $qu);
          }
      }
Post a Comment

There are currently no comments in this forum.

FOSS Factory Source